Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide wen_restart and do not take default value for now. #33637

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

wen-coding
Copy link
Contributor

--wen_restart not ready yet, hide it for now and do not take default value so not to break wait_for_supermajority.

Copy link
Contributor

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the initial PR, I see that you added the arg but didn't actually connect it to anything. Ie, nothing in solana/validator/src/main.rs actually reads the wen_restart arg. More so, the field is not set in ValidatorConfig struct that is passed to Validator::new(). So, ValidatorConfig will just populate that field with its' default which is None.

I'm fine just marking this hidden for now, but arguably adding to the CLI could have waited until things were fully plumbed (unless not plumbing it down was an oversight).

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #33637 (aab0d6d) into master (a226783) will decrease coverage by 0.1%.
Report is 2 commits behind head on master.
The diff coverage is 0.0%.

@@            Coverage Diff            @@
##           master   #33637     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         806      806             
  Lines      217506   217506             
=========================================
- Hits       178038   177989     -49     
- Misses      39468    39517     +49     

@wen-coding wen-coding merged commit 7c80fa1 into solana-labs:master Oct 10, 2023
16 checks passed
@wen-coding wen-coding deleted the hide_wen_restart_feature branch October 10, 2023 22:06
@steviez steviez linked an issue Oct 10, 2023 that may be closed by this pull request
gregcusack pushed a commit to gregcusack/solana that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validator cli is broken with --wait-for-supermajority
3 participants