Remove dummy entries in Blockstore special columns (part 2)

[steviez]

Problem

#33511 previously attempted to make Blockstore::open() code remove dummy entries to enable the special case check that #33534 added. However, this change was flawed:

• The lines to remove the dummy entries was added to Blockstore::initialize_transaction_status_index()
• Blockstore::initialize_transaction_status_index() would only get called if the TransactionStatusIndex entries are not populated
• The previous code populated the TransactionStatusIndex entries and the special columns dummy entries at the same time

Thus, the logic to cleanup the dummy entries would only get called if TransactionStatusIndex entries are absent. But, the case where we need to clean up dummy entries is the case where TransactionStatusIndex` entries are present.

Summary of Changes

• Rename the initialization function and ensure it is always called at open
• Stop populating TransactionStatusIndex entries
  • These are now unused, and if the ledger is opened with an old software version that uses these entries, it will re-populate them
  • For now, I left any existing TransactionStatusIndex entries untouched as @CriesofCarrots previously expressed an idea to me of being able to use values in these entries to detect when the ledger is fully cleaned of old-key formats

[codecov]

Codecov Report

Merging #33649 (a4c7cf9) into master (4042079) will decrease coverage by 0.1%.
Report is 1075 commits behind head on master.
The diff coverage is 87.5%.

@@            Coverage Diff            @@
##           master   #33649     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         766      806     +40     
  Lines      209084   217450   +8366     
=========================================
+ Hits       171145   177992   +6847     
- Misses      37939    39458   +1519