Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockstore: clean/save old TransactionMemos sensibly #33678

Merged
merged 8 commits into from
Oct 13, 2023

Conversation

CriesofCarrots
Copy link
Contributor

Problem

As of this commit, the compaction-filter purge includes the TransactionMemos column. For new TransactionMemos that include Slot in the key, the filter works as expected, and purges slots older than oldest_slot. However, old TransactionMemos that don't include Slot in the key are currently set to all be purged on the first periodic cleanup. This is because C::slot(C::index()) always returns 0 for these entries.

Summary of Changes

Add a field to OldestSlot to track when slot-0 entries should be cleaned
Plumb into PurgedSlotFilter

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #33678 (d62ca06) into master (ac788ab) will increase coverage by 0.0%.
Report is 1 commits behind head on master.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##           master   #33678    +/-   ##
========================================
  Coverage    81.8%    81.8%            
========================================
  Files         806      806            
  Lines      217588   217673    +85     
========================================
+ Hits       178106   178206   +100     
+ Misses      39482    39467    -15     

@CriesofCarrots CriesofCarrots merged commit 01a3b1b into solana-labs:master Oct 13, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants