sort ancient append vec target_slots_sorted #33729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33729 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 806 806
Lines 217854 217873 +19
=======================================
+ Hits 178207 178259 +52
+ Misses 39647 39614 -33 |
HaoranYi
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When we disable rewrites, ancient append vec packing will run to combine old slots together.
There is a field
target_slots_sortedwhich didn't end up getting sorted. Previously, this was irrelevantly incorrect. However, other changes coming soon rely on this being sorted.Summary of Changes
Sort
target_slots_sorted.Fixes #