Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades lock_api to v0.4.10 #33736

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

brooksprumo
Copy link
Contributor

Problem

The lock_api dependency is old. I'd like to use SeqLock in accounts-db, which uses lock_api internally. However, lock_api had a breaking API change after v0.4.6, and SeqLock requires the new API.

See #33696 for more information/usage.

Summary of Changes

Upgrade lock_api.

@brooksprumo brooksprumo self-assigned this Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #33736 (ab8b157) into master (d948e5b) will increase coverage by 0.0%.
Report is 11 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #33736   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         806      806           
  Lines      217851   217851           
=======================================
+ Hits       178204   178248   +44     
+ Misses      39647    39603   -44     

@brooksprumo brooksprumo marked this pull request as ready for review October 17, 2023 20:48
@brooksprumo brooksprumo requested a review from yihau October 17, 2023 20:48
Copy link
Member

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪖

@brooksprumo brooksprumo merged commit 785959b into solana-labs:master Oct 18, 2023
25 checks passed
@brooksprumo brooksprumo deleted the bump/lock-api branch October 18, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants