simplifies pull-responses handling #33743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following: solana-labs#33722 from pubkey in PullResponse is no longer used in processing pull-responses and as a result the code can be simplified.
behzadnouri
force-pushed
the
gossip-handle-pull-response
branch
from
4bbeac4 to
cda6b59
Compare
Codecov Report
@@ Coverage Diff @@
## master #33743 +/- ##
=======================================
Coverage 81.7% 81.7%
=======================================
Files 806 806
Lines 217859 217841 -18
=======================================
- Hits 178199 178192 -7
+ Misses 39660 39649 -11 |
gregcusack
approved these changes
Oct 18, 2023
Comment on lines
-2169
to
-2174
| from: &Pubkey, | ||
| crds_values: Vec<CrdsValue>, | ||
| timeouts: &CrdsTimeouts, | ||
| ) -> (usize, usize, usize) { | ||
| let len = crds_values.len(); | ||
| trace!("PullResponse me: {} from: {} len={}", self.id(), from, len); |
There was a problem hiding this comment.
ya didn't know if we wanted to leave this in for debugging purposes. should have asked. not having this makes the rest of the upstream code much simpler. good find. thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Following: #33722
frompubkey in PullResponse is no longer used in processing pull-responses and so the code can be simplified.Summary of Changes
simplified pull-response handling.