program::message::AccountKeys: Clone, Default, Debug, Eq
#33749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a pretty standard set of traits to implement on most types. Both `Pubkey` and `LoadedAddresses` contained within the `AccountKeys` already implement them. Doing the same for `AccountKeys` could simplify unit tests and/or some common value manipulation logic.
ilya-bobyr
changed the title
Clone, Default, Debug, Eq
Codecov Report
@@ Coverage Diff @@
## master #33749 +/- ##
=========================================
- Coverage 81.8% 81.7% -0.1%
=========================================
Files 806 806
Lines 217894 217900 +6
=========================================
- Hits 178256 178240 -16
- Misses 39638 39660 +22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a pretty standard set of traits to implement on most types. Both
PubkeyandLoadedAddressescontained within theAccountKeysalready implement them. Doing the same forAccountKeyscould simplify unit tests and/or some common value manipulation logic.