Custom debug impl for LoadedPrograms cache #33808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33808 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 807 807
Lines 217414 217406 -8
=========================================
- Hits 178031 178024 -7
+ Misses 39383 39382 -1 |
Lichtso
reviewed
Oct 21, 2023
Lichtso
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
LoadedProgramscurrently clonesDebugtrait. But, not all information is useful for debugging. A custom impl will be more useful.Summary of Changes
Implement debug for LoadedPrograms cache.
Fixes #