Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses AccountHash in CalculateHashIntermediate #33822

Conversation

brooksprumo
Copy link
Contributor

Problem

CalculateHashIntermediate has a hash field that is an account's hash, but it uses a bare Hash type instead of AccountHash.

Summary of Changes

Make CalculateHashIntermediate::hash an AccountHash.

@brooksprumo brooksprumo self-assigned this Oct 24, 2023
pub struct CalculateHashIntermediate {
pub hash: Hash,
pub hash: AccountHash,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the main change.

@brooksprumo brooksprumo marked this pull request as ready for review October 24, 2023 02:12
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #33822 (e87b9d8) into master (8954689) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           master   #33822   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         807      807           
  Lines      217305   217289   -16     
=======================================
+ Hits       177935   177947   +12     
+ Misses      39370    39342   -28     

Copy link
Contributor

@yhchiang-sol yhchiang-sol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. I think the change should be self-explained, but do we consider renaming CalculateHashIntermediate to something like CalculateAccountHashIntermediate to avoid confusion?

@brooksprumo
Copy link
Contributor Author

do we consider renaming CalculateHashIntermediate to something like CalculateAccountHashIntermediate to avoid confusion?

Yeah, we could consider renaming to something better.

@brooksprumo brooksprumo merged commit 2f024f0 into solana-labs:master Oct 24, 2023
17 checks passed
@brooksprumo brooksprumo deleted the account-hash/calculate-hash-intermediate branch October 24, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants