-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes Default and pub from CumulativeOffset #33840
Removes Default and pub from CumulativeOffset #33840
Conversation
} | ||
|
||
pub trait ExtractSliceFromRawData<'b, T: 'b> { | ||
trait ExtractSliceFromRawData<'b, T: 'b> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this trait was public, and the extract
function takes a CumulativeOffset
, that meant CumulativeOffset
needed to be public. But extract
is only called in this file, so the trait does not need to be public either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## master #33840 +/- ##
=======================================
Coverage 81.8% 81.9%
=======================================
Files 809 809
Lines 217712 217627 -85
=======================================
- Hits 178295 178250 -45
+ Misses 39417 39377 -40 |
b3dd36d
to
00ce0c2
Compare
Rebased and force-pushed to address merge conflict. No actual changes were made. |
Problem
CumulativeOffset
and its fields are marked public, but are only used withinaccounts_hash.rs
.index
will change to a two-element array. A default doesn't necessarily make sense, as we'll always need at least one valid index to be set.Summary of Changes
Remove
pub
andDefault
.