Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransactionScheduler: Scheduler Count and Timing metrics #33893

Merged
merged 5 commits into from
Nov 17, 2023

Conversation

apfitzge
Copy link
Contributor

Problem

  • Currently no metrics for number of packets being received and scheduled by the scheduler
  • Currently no metrics for amount of time spent in each code section in the scheduler

Summary of Changes

  • Add metrics for number of packets received, dropped in different ways, scheduled etc
  • Add metrics for amount of time spent in major code sections: decision-making, scheduling, receiving, buffering
  • All metrics reports on a 1s interval

Fixes #

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #33893 (c3ddff6) into master (ba112a0) will increase coverage by 0.0%.
Report is 144 commits behind head on master.
The diff coverage is 95.9%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #33893    +/-   ##
========================================
  Coverage    81.8%    81.9%            
========================================
  Files         810      810            
  Lines      218148   218255   +107     
========================================
+ Hits       178650   178812   +162     
+ Misses      39498    39443    -55     

@apfitzge apfitzge marked this pull request as ready for review October 27, 2023 08:31
@apfitzge apfitzge requested a review from tao-stones October 27, 2023 08:31
@apfitzge apfitzge requested a review from tao-stones November 16, 2023 21:19
Copy link
Contributor

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - a good starting with these new counters, and planned collected fee counter in separate PR. Can add/adjust as needed when testing

@apfitzge apfitzge merged commit 9bb82a3 into solana-labs:master Nov 17, 2023
32 checks passed
@apfitzge apfitzge deleted the scheduler-metrics branch November 17, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants