Adds logs for starting/stopping of the background account hasher #33903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33903 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 811 811
Lines 218163 218166 +3
=======================================
+ Hits 178734 178754 +20
+ Misses 39429 39412 -17 |
yhchiang-sol
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When the background account hasher thread is started/stopped, there are no logs indicating such. This likely isn't a big deal but if there's ever an error that causes the underlying channel to disconnect early, it would be helpful to have a log message indicating as such.
Summary of Changes
Add logs for when the background account hasher starts and stops.