solana-tokens: unpub/remove some helpers #33937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 31, 2023 15:57
willhickey
approved these changes
Nov 1, 2023
CriesofCarrots
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #33937 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 809 809
Lines 218241 218238 -3
=========================================
- Hits 178794 178766 -28
- Misses 39447 39472 +25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
solana-tokensis overly public in its interface.Summary of Changes
Reduce the scope of some helper functions. crates.io reports that no projects are using
solana-tokensas a dependency, so this shouldn't break anyone.Remove a function that isn't being used (and we couldn't tell, bc pub)