Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy: Uses .into() when .try_into() is infallible #34049

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

brooksprumo
Copy link
Contributor

Problem

There are nightly clippy warnings that will prevent upgrading our stable Rust version.

For this PR, it's this one: https://rust-lang.github.io/rust-clippy/master/index.html#/try_into

Summary of Changes

Replaces .try_into() with .into().

@brooksprumo brooksprumo self-assigned this Nov 13, 2023
@brooksprumo brooksprumo marked this pull request as ready for review November 13, 2023 20:48
@brooksprumo
Copy link
Contributor Author

@samkim-crypto This fix was auto-suggested by clippy. Want to double check with you to ensure it is safe.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #34049 (62951cd) into master (47a98eb) will decrease coverage by 0.1%.
Report is 3 commits behind head on master.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           master   #34049     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%     
=========================================
  Files         811      811             
  Lines      219552   219552             
=========================================
- Hits       179902   179893      -9     
- Misses      39650    39659      +9     

Copy link
Contributor

@samkim-crypto samkim-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks good to me, thanks!

@brooksprumo brooksprumo merged commit ea98c0e into solana-labs:master Nov 14, 2023
32 checks passed
@brooksprumo brooksprumo deleted the clippy/into branch November 14, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants