Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean feature: vote_stake_checked_instructions #34079

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Nov 15, 2023

Problem

vote_stake_checked_instructions feature is active on all clusters and should be cleaned up

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #34079 (42b097e) into master (87d20ae) will decrease coverage by 0.1%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34079     +/-   ##
=========================================
- Coverage    81.9%    81.8%   -0.1%     
=========================================
  Files         816      816             
  Lines      219718   219711      -7     
=========================================
- Hits       179994   179934     -60     
- Misses      39724    39777     +53     

@jstarry jstarry requested a review from joncinque November 16, 2023 04:52
joncinque
joncinque previously approved these changes Nov 16, 2023
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jstarry jstarry force-pushed the clean-feature/vote_stake_checked_instructions branch from 04b2860 to 42b097e Compare November 16, 2023 13:45
@jstarry
Copy link
Member Author

jstarry commented Nov 17, 2023

I had to resolve some merge conflicts, need another approval, thanks!

Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good!

@jstarry jstarry merged commit 85db4da into solana-labs:master Nov 17, 2023
32 checks passed
@jstarry jstarry deleted the clean-feature/vote_stake_checked_instructions branch November 17, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants