clean feature: libsecp256k1_0_5_upgrade_enabled #34080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34080 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 811 811
Lines 219452 219432 -20
=======================================
- Hits 179768 179753 -15
+ Misses 39684 39679 -5 |
t-nelson
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
libsecp256k1_0_5_upgrade_enabledfeature is enabled on all the clusters and can be cleaned upSummary of Changes
There were a bunch of tests that intentionally disabled the feature but they all still pass when the feature is enabled 🤷🏻♂️
Fixes #