cleanup feature code after mainnet-beta activation of DdLwVYuvDz26JohmgSbA7mjpJFgX5zP2dkp8qsF2C33V

[tao-stones]

Problem

feature DdLwVYuvDz26JohmgSbA7mjpJFgX5zP2dkp8qsF2C33V #27839 has been activated everywhere.

Summary of Changes

cleanup feature code

Fixes #

[tao-stones]

solana feature status DdLwVYuvDz26JohmgSbA7mjpJFgX5zP2dkp8qsF2C33V
Feature                                      | Status                  | Activation Slot | Description
DdLwVYuvDz26JohmgSbA7mjpJFgX5zP2dkp8qsF2C33V | pending until epoch 533 | NA              | cap transaction accounts data size up to a limit #27839

solana feature status DdLwVYuvDz26JohmgSbA7mjpJFgX5zP2dkp8qsF2C33V -ud
Feature                                      | Status                  | Activation Slot | Description
DdLwVYuvDz26JohmgSbA7mjpJFgX5zP2dkp8qsF2C33V | active since epoch 557  | 240624000       | cap transaction accounts data size up to a limit #27839

solana feature status DdLwVYuvDz26JohmgSbA7mjpJFgX5zP2dkp8qsF2C33V -ut
Feature                                      | Status                  | Activation Slot | Description
DdLwVYuvDz26JohmgSbA7mjpJFgX5zP2dkp8qsF2C33V | active since epoch 516  | 217388260       | cap transaction accounts data size up to a limit #27839

[brooksprumo]

Over on Discord it was proposed that we don't immediately clean up feature gate code¹, and instead wait until the next version rolls out on mnb. This would allow master to always replay a ledger created by stable, which is a common use-case for the VM/runtime team.

I see this feature gate has already moved to the "awaiting cleanup" section² on the feature gate activation schedule as well.

It seems reasonable to wait to clean up featurization if it helps another team. It also seems that this feature gate is quite localized and thus won't dramatically reduce complexity by removing the featurization code (which would be a reason to justify removing the code now vs later).

Wdyt about waiting?

Footnotes

1. https://discord.com/channels/428295358100013066/910937142182682656/1165996903163498556 ↩

2. https://github.com/solana-labs/solana/wiki/Feature-Gate-Activation-Schedule#activated-awaiting-cleanup ↩

[codecov]

Codecov Report

Merging #34089 (09bb723) into master (39f2866) will increase coverage by 0.0%.
Report is 9 commits behind head on master.
The diff coverage is 100.0%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #34089   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         819      819           
  Lines      220912   220904    -8     
=======================================
+ Hits       180865   180911   +46     
+ Misses      40047    39993   -54     

[tao-stones]

Thanks for pointing it out, totally agree. Just want to put out the PR avoid another content switch. Change it to Draft until Feature Activation Schedule rolls this into "do clean up" stage.

[brooksprumo]

Just want to put out the PR avoid another content switch.

I just did the same thing, so I totally understand.

Change it to Draft until Feature Activation Schedule rolls this into "do clean up" stage.

Sounds good. I'm going to remove myself as a reviewer for now. Once the clean up stage is open, please do re-tag me to review. Thanks!

[brooksprumo]

Over on Discord it was proposed that we don't immediately clean up feature gate code, and instead wait until the next version rolls out on mnb. This would allow master to always replay a ledger created by stable, which is a common use-case for the VM/runtime team.

Welp, looks like this was reversed, lol.
https://discord.com/channels/428295358100013066/910937142182682656/1184177692745142313

I'll re-review this PR. It also looks like there are file conflicts that need to be resolved now.

[brooksprumo]

Lgtm. Please re-request a review after conflicts are resolved.

[tao-stones]

Over on Discord it was proposed that we don't immediately clean up feature gate code, and instead wait until the next version rolls out on mnb. This would allow master to always replay a ledger created by stable, which is a common use-case for the VM/runtime team.

Welp, looks like this was reversed, lol.

Yeah, the flood gate is now open 😜 (... and all the rebases)

[brooksprumo]

lgtm