stake: Remove feature stake_merge_with_unmatched_credits_observed
#34114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While going through the stake program code, I noticed that
stake_merge_with_unmatched_credits_observed
is still in there, when it's been enabled for over two years. And then I confirmed that it was mine in #18985Summary of Changes
Remove the feature gate, and update a test that was an old function. The removed test case is no longer valid since we relaxed the
credits_observed
equality requirement.Fixes #