Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stake: Remove feature stake_merge_with_unmatched_credits_observed #34114

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

joncinque
Copy link
Contributor

Problem

While going through the stake program code, I noticed that stake_merge_with_unmatched_credits_observed is still in there, when it's been enabled for over two years. And then I confirmed that it was mine in #18985

Summary of Changes

Remove the feature gate, and update a test that was an old function. The removed test case is no longer valid since we relaxed the credits_observed equality requirement.

Fixes #

@joncinque joncinque requested a review from jstarry November 16, 2023 17:34
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #34114 (fe28b06) into master (f349d71) will increase coverage by 0.0%.
Report is 4 commits behind head on master.
The diff coverage is 100.0%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #34114   +/-   ##
=======================================
  Coverage    81.9%    81.9%           
=======================================
  Files         816      816           
  Lines      219717   219701   -16     
=======================================
- Hits       179964   179959    -5     
+ Misses      39753    39742   -11     

@joncinque joncinque merged commit 6280b1e into solana-labs:master Nov 17, 2023
32 checks passed
@joncinque joncinque deleted the stkrmf branch November 17, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants