Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy: Allow enum variant names in generated google.bigtable.v2 #34126

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

brooksprumo
Copy link
Contributor

Problem

New clippy lints are preventing us from upgrading our nightly rust in #34118. Here's the build: https://buildkite.com/solana-labs/solana/builds/104515#018bd9d3-5bfd-41b5-9cc2-2a9d810c0360. Here's what the error looks like:

error: variant name ends with the enum's name
   --> /solana/storage-bigtable/proto/google.bigtable.v2.rs:418:9
    |
418 |         PassAllFilter(bool),
    |         ^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
    = note: `-D clippy::enum-variant-names` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::enum_variant_names)]`

Summary of Changes

Explicitly allow this clippy lint.

@brooksprumo brooksprumo self-assigned this Nov 16, 2023
@brooksprumo brooksprumo marked this pull request as ready for review November 16, 2023 22:24
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #34126 (71d9116) into master (32993b2) will increase coverage by 0.0%.
Report is 1355 commits behind head on master.
The diff coverage is 90.9%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #34126      +/-   ##
==========================================
  Coverage    81.8%    81.9%              
==========================================
  Files         766      818      +52     
  Lines      209077   219938   +10861     
==========================================
+ Hits       171130   180227    +9097     
- Misses      37947    39711    +1764     

@brooksprumo brooksprumo merged commit 7d7d72e into solana-labs:master Nov 16, 2023
32 checks passed
@brooksprumo brooksprumo deleted the clippy/bigtable branch November 16, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants