Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clippy: Replaces .get(0) with .first() #34143

Merged
merged 1 commit into from
Nov 17, 2023
Merged

clippy: Replaces .get(0) with .first() #34143

merged 1 commit into from
Nov 17, 2023

Conversation

brooksprumo
Copy link
Contributor

Problem

There are nightly clippy warnings that will prevent upgrading our stable Rust version.

For this PR, it's this one: https://rust-lang.github.io/rust-clippy/master/index.html#/get(0)

Summary of Changes

Replaces .get(0) with .first().

@brooksprumo brooksprumo self-assigned this Nov 17, 2023
@brooksprumo brooksprumo marked this pull request as ready for review November 17, 2023 14:21
@brooksprumo brooksprumo requested a review from yihau November 17, 2023 14:21
yihau
yihau approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪖

@brooksprumo brooksprumo merged commit 851be08 into solana-labs:master Nov 17, 2023
30 of 32 checks passed
@brooksprumo brooksprumo deleted the clippy/first branch November 17, 2023 15:03
@brooksprumo
Copy link
Contributor Author

Oops. I hit merge too early, before coverage had actually finished. It has since completed successfully.

@willhickey willhickey mentioned this pull request Mar 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihau yihau yihau approved these changes

Assignees

@brooksprumo brooksprumo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brooksprumo @yihau