Use Vec::with_capacity() to avoid reallocations with repeated push()'s #34242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The length of tx_cells is known before the loop that populates it, so we can appropriately allocate the Vec immediatley to avoid any reallocations.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34242 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 819 819
Lines 219387 219387
=======================================
+ Hits 179690 179768 +78
+ Misses 39697 39619 -78 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The length of tx_cells is known at the start, so we can size the Vec appropriately off the bat to avoid the reallocations.
Summary of Changes
vec![] ==> Vec::with_capacity()