generalize message type for runtime-transaction #34276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34276 +/- ##
========================================
Coverage 81.9% 81.9%
========================================
Files 819 819
Lines 220228 220418 +190
========================================
+ Hits 180556 180727 +171
- Misses 39672 39691 +19 |
apfitzge
reviewed
Nov 30, 2023
tao-stones
force-pushed
the
runtime-transaction-generic
branch
from
be97ec4 to
3344e0c
Compare
tao-stones
force-pushed
the
runtime-transaction-generic
branch
from
3344e0c to
17223b8
Compare
apfitzge
reviewed
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Generalize message type for RuntimeTransaction types could decouple sdk, also better reflect the nature relationship between Transaction and Message.
Summary of Changes
Fixes #