Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes epoch_accounts_hash featurization #34417

Merged

Conversation

brooksprumo
Copy link
Contributor

Problem

Now that the Epoch Accounts Hash feature gate has been enabled on all clusters, its featurization code can be removed.

Summary of Changes

Remove it.

@brooksprumo brooksprumo added the feature-gate Pull Request adds or modifies a runtime feature gate label Dec 12, 2023
@brooksprumo brooksprumo self-assigned this Dec 12, 2023
@brooksprumo brooksprumo linked an issue Dec 12, 2023 that may be closed by this pull request
3 tasks
@brooksprumo
Copy link
Contributor Author

Looks like cleaning up activated feature gates will NOT be delayed by a minor version. Here's the announcement: https://discord.com/channels/428295358100013066/910937142182682656/1184177692745142313

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #34417 (13282ab) into master (337c233) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34417     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         819      819             
  Lines      221037   221028      -9     
=========================================
- Hits       181028   180976     -52     
- Misses      40009    40052     +43     

@brooksprumo brooksprumo force-pushed the eah/remove-featurization branch from 5996716 to 6fe34a3 Compare December 12, 2023 21:12
@brooksprumo brooksprumo force-pushed the eah/remove-featurization branch from 6fe34a3 to 13282ab Compare December 12, 2023 21:19
@brooksprumo brooksprumo marked this pull request as ready for review December 12, 2023 21:40
Copy link
Contributor

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo brooksprumo merged commit 0b6d939 into solana-labs:master Dec 13, 2023
34 checks passed
@brooksprumo brooksprumo deleted the eah/remove-featurization branch December 13, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Projects
Development

Successfully merging this pull request may close these issues.

Feature Gate: Add Epoch Accounts Hash
2 participants