Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove feature set from compute budget processor #34472

Conversation

tao-stones
Copy link
Contributor

Problem

after all features related to compute_budget_processor() are activated everywhere, it no longer needs feature-set as parameter

Summary of Changes

  • remove feature-set as parameter

Fixes #

@tao-stones tao-stones force-pushed the remove-feature_set-from-compute-budget-processor branch from 7f63704 to bdf7d0b Compare December 15, 2023 00:36
@tao-stones tao-stones force-pushed the remove-feature_set-from-compute-budget-processor branch 2 times, most recently from 995cfd6 to bee11c1 Compare December 15, 2023 00:53
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #34472 (583700d) into master (f214a82) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34472     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         819      819             
  Lines      220848   220837     -11     
=========================================
- Hits       180790   180750     -40     
- Misses      40058    40087     +29     

@tao-stones tao-stones force-pushed the remove-feature_set-from-compute-budget-processor branch from bee11c1 to 583700d Compare December 15, 2023 19:28
@tao-stones tao-stones marked this pull request as ready for review December 15, 2023 19:29
@tao-stones tao-stones requested a review from apfitzge December 15, 2023 20:54
Copy link
Contributor

@apfitzge apfitzge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@tao-stones tao-stones merged commit 86c88d7 into solana-labs:master Dec 15, 2023
34 checks passed
@tao-stones tao-stones deleted the remove-feature_set-from-compute-budget-processor branch December 15, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants