Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConcurrentBloomInterval #34486

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

apfitzge
Copy link
Contributor

@apfitzge apfitzge commented Dec 15, 2023

Problem

  • Want to do earlier filtering for keys we know to not pay fees

Summary of Changes

  • ConcurrentBloomInterval - will be used to store invalid fee paying keys and filter them out quickly. These keys should be reset periodically, so wrapped in an AtomicInterval so that only 1 thread actually does the clearing.
  • Eventually, I'm hoping to use this in both sigverify and banking stage, so wanted to define the struct somewhere both perf and core can use it.

Fixes #

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (1db76cf) 81.8% compared to head (556d18f) 81.8%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #34486   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         822      822           
  Lines      221573   221587   +14     
=======================================
+ Hits       181341   181420   +79     
+ Misses      40232    40167   -65     

}

// Directly allow all methods of `AtomicBloom` to be called on `AtomicBloomInterval`.
impl<T: BloomHashIndex> Deref for AtomicBloomInterval<T> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is purely for convenience.

@apfitzge apfitzge force-pushed the resetting_atomic_bloom branch from ce43e17 to 556d18f Compare December 21, 2023 15:07
@apfitzge apfitzge changed the title AtomicBloomInterval ConcurrentBloomInterval Dec 21, 2023
@apfitzge apfitzge marked this pull request as ready for review December 21, 2023 20:54
@apfitzge apfitzge merged commit 6dea5a2 into solana-labs:master Jan 2, 2024
34 checks passed
@apfitzge apfitzge deleted the resetting_atomic_bloom branch January 2, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants