Add RPC bench threads to accounts-cluster-bench #34520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakridge
force-pushed
the
accounts-cluster-rpc
branch
5 times, most recently
from
a09f55c to
03b717f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34520 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 822 822
Lines 221504 221504
=======================================
+ Hits 181289 181343 +54
+ Misses 40215 40161 -54 |
alessandrod
reviewed
Dec 19, 2023
Comment on lines
+354
to
+357
| if last_error.elapsed().as_secs() > 2 { | ||
| info!("get_slot error: {:?}", e); | ||
| last_error = Instant::now(); | ||
| } |
There was a problem hiding this comment.
Maybe dedupe this into a closure or fn in case we want to twiddle the frequency or make other changes to all RpcBench variants?
There was a problem hiding this comment.
I can do this in a follow-up, requires some re-shuffling.
sakridge
force-pushed
the
accounts-cluster-rpc
branch
from
03b717f to
c8b661e
Compare
sakridge
force-pushed
the
accounts-cluster-rpc
branch
from
c8b661e to
b1190c4
Compare
github-actions
bot
added
the
stale
github-actions
bot
removed
the
stale
CriesofCarrots
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
No way to benchmark the RPC subsystem while creating large numbers of accounts like with accounts-cluster-bench.
Summary of Changes
Add RPC benchmarking threads to accounts-cluster-bench which can query for the created accounts while the bench is running.
Fixes #