Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chain-joining thread-selection #34554

Merged

Conversation

apfitzge
Copy link
Contributor

@apfitzge apfitzge commented Dec 21, 2023

Problem

  • This feature helped in simulated traffic with forking/joining and txs were relatively cheap, but is not helping w/ mnb traffic where the txs are more expensive

Summary of Changes

  • Remove this feature for the time being
  • Removing this will increase the number of unschedulable transactions, but will also lead to better load balancing for our highest priority transactions.

Fixes #

@apfitzge apfitzge force-pushed the scheduler_no_look_ahead_joining branch from d8f252b to 127ff9b Compare December 21, 2023 15:02
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (47b4075) 81.8% compared to head (8f2f1b8) 81.8%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34554     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         824      824             
  Lines      222486   222462     -24     
=========================================
- Hits       182090   182039     -51     
- Misses      40396    40423     +27     

@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Jan 5, 2024
@apfitzge apfitzge force-pushed the scheduler_no_look_ahead_joining branch from 127ff9b to 8f2f1b8 Compare January 5, 2024 17:13
@apfitzge apfitzge removed the stale [bot only] Added to stale content; results in auto-close after a week. label Jan 5, 2024
@apfitzge apfitzge marked this pull request as ready for review January 5, 2024 17:58
@apfitzge apfitzge requested a review from tao-stones January 5, 2024 17:58
Copy link
Contributor

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apfitzge apfitzge merged commit ac04a75 into solana-labs:master Jan 10, 2024
36 checks passed
@apfitzge apfitzge deleted the scheduler_no_look_ahead_joining branch January 10, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants