Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solana program deployment failed because blockhash was expired during… #34621

Conversation

godmodegalactus
Copy link
Contributor

… simulation, So we ignore these types of errors as we are going to retry with new blockhash anyways

Problem

While deploying a big program the blockhash expires, and rpc during simulation will fail with message BlockhashNotFound. This makes the program deployment fail.

Summary of Changes

Ignoring the BlockhashNotFound transaction error as cli will retry to send the transaction with newer Blockhash anyways.

Fixes #

… simulation, So we ignore these types of errors as we are going to retry with new blockhash anyways
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6dea5a2) 81.8% compared to head (e75cf47) 81.8%.
Report is 25 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #34621   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         824      824           
  Lines      222260   222257    -3     
=======================================
+ Hits       181889   181922   +33     
+ Misses      40371    40335   -36     

Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the fix! Just a little nit to avoid multiple matches to make the fix clearer (I hope). Let me know what you think!

Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@joncinque joncinque merged commit bbb4118 into solana-labs:master Jan 5, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants