This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Upgrade sbf tests to use bpf loader v3 #34691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaoranYi
force-pushed
the
2024_jan_8_upgrade_bpf_test_v2
branch
from
2bce7a9 to
c8a66d0
Compare
HaoranYi
force-pushed
the
2024_jan_8_upgrade_bpf_test_v2
branch
from
c8a66d0 to
685423b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #34691 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 824 824
Lines 222687 222687
=======================================
+ Hits 182245 182303 +58
+ Misses 40442 40384 -58 |
HaoranYi
force-pushed
the
2024_jan_8_upgrade_bpf_test_v2
branch
from
e5a2d37 to
6847c6c
Compare
HaoranYi
force-pushed
the
2024_jan_8_upgrade_bpf_test_v2
branch
from
6f27bf8 to
d30de0d
Compare
added 8 commits
January 8, 2024 22:59
HaoranYi
changed the title
HaoranYi
changed the title
pgarg66
reviewed
Jan 11, 2024
pgarg66
reviewed
Jan 11, 2024
pgarg66
reviewed
Jan 11, 2024
HaoranYi
changed the title
pgarg66
reviewed
Jan 11, 2024
pgarg66
reviewed
Jan 11, 2024
|
Looks good to me! |
Lichtso
approved these changes
Jan 13, 2024
|
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
mergify bot
pushed a commit
that referenced
this pull request
Feb 9, 2024
* update sbf test to use bpf_loader v2 * update test_program_sbf_invoke_sanity test * update test bpf program owner * update test_program_sbf_invoke_upgradeable_via_cpi * update test_program_sbf_disguised_as_sbf_loader * update test_program_reads_from_program_account * update test_program_sbf_program_id_spoofing * update test_program_sbf_caller_has_access_to_cpi_program * update 3 more tests * fix program buffer size in minimul for rent exempt calculation * more test updates * more update * more test updates * comments * undo c format * typo * add sol_alloc_free not deployable and deployable tests * comments * review feedback - move buffer_keypair and program_keypair inside callee fn. * more refactor * delete sof_alloc_free_syscall enabled tests * revert lamport change --------- Co-authored-by: HaoranYi <haoran.yi@solana.com> (cherry picked from commit 8869d0c) # Conflicts: # programs/sbf/tests/programs.rs
sakridge
added a commit
that referenced
this pull request
Feb 10, 2024
…35162) * Upgrade sbf tests to use bpf loader v3 (#34691) * update sbf test to use bpf_loader v2 * update test_program_sbf_invoke_sanity test * update test bpf program owner * update test_program_sbf_invoke_upgradeable_via_cpi * update test_program_sbf_disguised_as_sbf_loader * update test_program_reads_from_program_account * update test_program_sbf_program_id_spoofing * update test_program_sbf_caller_has_access_to_cpi_program * update 3 more tests * fix program buffer size in minimul for rent exempt calculation * more test updates * more update * more test updates * comments * undo c format * typo * add sol_alloc_free not deployable and deployable tests * comments * review feedback - move buffer_keypair and program_keypair inside callee fn. * more refactor * delete sof_alloc_free_syscall enabled tests * revert lamport change --------- Co-authored-by: HaoranYi <haoran.yi@solana.com> (cherry picked from commit 8869d0c) # Conflicts: # programs/sbf/tests/programs.rs * fix merge conflicts * update tests to avoid using the new test api from 1.18 * manually backport #34722 to fix a test * Ignore failing benchmark tests and fix compilation --------- Co-authored-by: HaoranYi <haoran.yi@gmail.com> Co-authored-by: HaoranYi <haoran.yi@solana.com> Co-authored-by: haoran <haoran@mbook> Co-authored-by: Stephen Akridge <sakridge@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Follow up #34194
Update programs/sbf/tests/programs.rs to use bpf_loader v3.
Summary of Changes
Fixes #