Filter out banks that have an older epoch #3472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3472 +/- ##
========================================
+ Coverage 79.3% 79.3% +<.1%
========================================
Files 152 154 +2
Lines 24089 24206 +117
========================================
+ Hits 19111 19217 +106
- Misses 4978 4989 +11 |
KirillLykov
pushed a commit
to KirillLykov/solana
that referenced
this pull request
Nov 5, 2024
Split the time taken by filter_executable_accounts() outside of program_cache_us. Filtering takes a considerable amount of time because account_matches_owners is pretty slow.
alessandrod
added a commit
to alessandrod/solana
that referenced
this pull request
Nov 5, 2024
Split the time taken by filter_executable_accounts() outside of program_cache_us. Filtering takes a considerable amount of time because account_matches_owners is pretty slow.
Lichtso
pushed a commit
to Lichtso/solana
that referenced
this pull request
Nov 7, 2024
Split the time taken by filter_executable_accounts() outside of program_cache_us. Filtering takes a considerable amount of time because account_matches_owners is pretty slow.
joncinque
pushed a commit
to joncinque/solana
that referenced
this pull request
Nov 7, 2024
…-labs#3482) Split the time taken by filter_executable_accounts() outside of program_cache_us. Filtering takes a considerable amount of time because account_matches_owners is pretty slow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Locktower initializes itself with the oldest frozen bank, but during epoch warmup, old frozen banks maybe presented as valid votes, even though they are from an older epoch.
Summary of Changes
Filter out old epochs.
Fixes #