Do not reserve QUIC stream capacity for unstaked client on forward port #34779
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #34779 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 825 825
Lines 223124 223150 +26
=========================================
+ Hits 182527 182540 +13
- Misses 40597 40610 +13 |
| .stream_load_capacity_overflow | ||
| .fetch_add(1, Ordering::Relaxed); | ||
| self.max_unstaked_load_in_throttling_window | ||
| .saturating_add(1) |
There was a problem hiding this comment.
What is the reasoning for this "+1"?
There was a problem hiding this comment.
This is to ensure staked connection get atleast 1 more stream than the unstaked connections.
The previous value (8) was lower than the stream count for unstaked connections. Doing this computationally helps make sure that the number will be correct, in case we change the other parameters that control stream counts for unstaked connections.
There was a problem hiding this comment.
Can we add a little comments there?
|
|
||
| pub(crate) struct StakedStreamLoadEMA { | ||
| current_load_ema: AtomicU64, | ||
| load_in_recent_interval: AtomicU64, | ||
| last_update: RwLock<Instant>, | ||
| stats: Arc<StreamStats>, | ||
| max_staked_load_in_ema_window: u64, | ||
| max_unstaked_load_in_throttling_window: u64, |
There was a problem hiding this comment.
I think we can use some comments to explain these two fields -- especially because the first one is the aggregate for all staked connections and the second is for that of the per unstaked connection.
Problem
TPU-ForwardQUIC streamer does not accept connections from unstaked peers, but it's reserving stream capacity from such peers. This capacity could be used for the connections from staked peers.Summary of Changes
Update calculations for stream capacity calculations to factor in if unstaked clients are supproted.
Fixes #