Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleans up snapshot errors #34831

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

brooksprumo
Copy link
Contributor

Problem

While working on #34799, a different solution was requested. So to prep for that, and have small/simple PRs to review, I identified some nits within the current snapshot errors.

Summary of Changes

  • Use the IoError alias
  • Put single quotes around paths
  • Reserve the use of : for source errors
  • Add more info (path/string/etc) to a few errors

@brooksprumo brooksprumo added the v1.17 PRs that should be backported to v1.17 label Jan 18, 2024
@brooksprumo brooksprumo self-assigned this Jan 18, 2024
Copy link
Contributor

mergify bot commented Jan 18, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@brooksprumo brooksprumo marked this pull request as ready for review January 18, 2024 16:29
@brooksprumo brooksprumo requested a review from apfitzge January 18, 2024 16:29
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (e2c2029) 81.7% compared to head (20e9d17) 81.7%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34831     +/-   ##
=========================================
- Coverage    81.7%    81.7%   -0.1%     
=========================================
  Files         825      825             
  Lines      223261   223270      +9     
=========================================
- Hits       182605   182582     -23     
- Misses      40656    40688     +32     

Copy link
Contributor

@apfitzge apfitzge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo brooksprumo merged commit b53915f into solana-labs:master Jan 18, 2024
36 checks passed
@brooksprumo brooksprumo deleted the snap/errors/cleanup branch January 18, 2024 18:42
mergify bot pushed a commit that referenced this pull request Jan 18, 2024
(cherry picked from commit b53915f)

# Conflicts:
#	runtime/src/snapshot_utils.rs
@brooksprumo brooksprumo removed the v1.17 PRs that should be backported to v1.17 label Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants