Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot archive uses version file from bank snapshot #34832

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

brooksprumo
Copy link
Contributor

Problem

When creating a snapshot archive, it needs a snapshot version file. Currently, we create that file from the snapshot version inside the snapshot package. However, we already wrote a snapshot version file as part of snapshotting the bank previously. So there's no need to write this file twice (and it'll make cleaning up the errors later easier too)!

Summary of Changes

Similar to the status cache, symlink the snapshot version file from the bank snapshot into the snapshot archive's staging directory.

@brooksprumo brooksprumo self-assigned this Jan 18, 2024
@brooksprumo brooksprumo added the v1.17 PRs that should be backported to v1.17 label Jan 18, 2024
Copy link
Contributor

mergify bot commented Jan 18, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@brooksprumo brooksprumo marked this pull request as ready for review January 18, 2024 17:27
@brooksprumo brooksprumo requested a review from apfitzge January 18, 2024 17:27
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e2c2029) 81.7% compared to head (31a7dc9) 81.7%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34832     +/-   ##
=========================================
- Coverage    81.7%    81.7%   -0.1%     
=========================================
  Files         825      825             
  Lines      223261   223258      -3     
=========================================
- Hits       182605   182588     -17     
- Misses      40656    40670     +14     

@brooksprumo brooksprumo removed the v1.17 PRs that should be backported to v1.17 label Jan 18, 2024
@brooksprumo brooksprumo merged commit 8f9d915 into solana-labs:master Jan 18, 2024
37 checks passed
@brooksprumo brooksprumo deleted the snap/version-file branch January 18, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants