blockstore: Adjust the error message for missing shreds #34833
Merged
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The log statement is currently a bit misleading, and could be interpretted as saying this routine deleted a shred. Adjust the log statement to state that this routine is looking for the shred but couldn't find it. Also, elevate the log to error level as inconsistent state across columns should not be happening.
t-nelson
approved these changes
Jan 18, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #34833 +/- ##
=========================================
- Coverage 81.7% 81.7% -0.1%
=========================================
Files 825 825
Lines 223263 223263
=========================================
- Hits 182624 182543 -81
- Misses 40639 40720 +81 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The log statement is currently a bit misleading, and could be interpretted as saying this routine deleted a shred.
Summary of Changes
Adjust the log statement to state that this routine is looking for the shred but couldn't find it. Also, elevate the log to error level as inconsistent state across columns should not be happening.
I updated from
warntoerrorfor visibility altho this function can technically handle the shred being absent.