Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly sets tests that does not handle transaction fee #34847

Merged

Conversation

tao-stones
Copy link
Contributor

Problem

Tests expect zero transaction fee without be explicit about it.

Summary of Changes

  • explicitly sets up tests with zero fee rate

Fixes #

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8f9d915) 81.8% compared to head (cfb6906) 81.7%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34847     +/-   ##
=========================================
- Coverage    81.8%    81.7%   -0.1%     
=========================================
  Files         825      825             
  Lines      223269   223271      +2     
=========================================
- Hits       182635   182619     -16     
- Misses      40634    40652     +18     

@tao-stones tao-stones requested a review from LucasSte January 18, 2024 23:56
@tao-stones tao-stones merged commit a57d612 into solana-labs:master Jan 19, 2024
35 checks passed
@tao-stones tao-stones deleted the harden-send-transaction-sve-tests branch January 19, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants