Bubble up genesis load errors instead of exiting #34851
Merged
+34
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steviez
force-pushed
the
genesis_err_plumbing
branch
from
3982309 to
56f97ba
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #34851 +/- ##
=========================================
- Coverage 81.7% 81.7% -0.1%
=========================================
Files 826 826
Lines 223168 223174 +6
=========================================
- Hits 182446 182411 -35
- Misses 40722 40763 +41 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the function
open_genesis_config()performs several operations that could fail, and unwraps / exits immediately.Summary of Changes
Bubble the error up to allow the caller to decide what to do with the result.
solana-validatorandsolana-ledger-toolwill essentially have unchanged behavior as they both exit if this result is bad. But, this change removes one more place that could kill the process