Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses accounts run and snapshot dir constants #34879

Merged

Conversation

brooksprumo
Copy link
Contributor

@brooksprumo brooksprumo commented Jan 22, 2024

Problem

The accounts run and snapshot directories are run and snapshot, respectively. We have constants for these, but they are not always used.

Summary of Changes

Uses accounts run and snapshot dir constants

@brooksprumo brooksprumo added the work in progress This isn't quite right yet label Jan 22, 2024
@brooksprumo brooksprumo self-assigned this Jan 22, 2024
@brooksprumo brooksprumo force-pushed the errors/accounts-dir-constants branch from 6424c1a to 976b973 Compare January 22, 2024 19:41
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (a5c470d) 81.7% compared to head (ab4fe21) 81.6%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34879     +/-   ##
=========================================
- Coverage    81.7%    81.6%   -0.2%     
=========================================
  Files         826      827      +1     
  Lines      223413   223819    +406     
=========================================
+ Hits       182614   182678     +64     
- Misses      40799    41141    +342     

@brooksprumo brooksprumo force-pushed the errors/accounts-dir-constants branch from 976b973 to ab4fe21 Compare January 22, 2024 23:19
@brooksprumo brooksprumo removed the work in progress This isn't quite right yet label Jan 22, 2024
@brooksprumo brooksprumo marked this pull request as ready for review January 23, 2024 00:43
@brooksprumo brooksprumo requested a review from apfitzge January 23, 2024 00:44
@brooksprumo brooksprumo merged commit 098076f into solana-labs:master Jan 23, 2024
36 checks passed
@brooksprumo brooksprumo deleted the errors/accounts-dir-constants branch January 23, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants