Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaces fs-err in snapshot_utils fns #34883

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Replaces fs-err in snapshot_utils fns #34883

merged 1 commit into from
Jan 22, 2024

Conversation

brooksprumo
Copy link
Contributor

Problem

We're trying to remove the fs-err crate. For more information, please refer to #34838.

Some uses of fs-err in snapshot_utils.rs can easily be replaced with their std::fs counterparts.

Summary of Changes

Replace 'em, and add the path info the error log.

@brooksprumo brooksprumo self-assigned this Jan 22, 2024
@brooksprumo brooksprumo marked this pull request as ready for review January 22, 2024 20:21
@brooksprumo brooksprumo requested a review from HaoranYi January 22, 2024 20:31
NxPKG
NxPKG reviewed Jan 22, 2024
View reviewed changes
Copy link

@NxPKG NxPKG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

HaoranYi
HaoranYi approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo brooksprumo added the automerge Merge this Pull Request automatically once CI passes label Jan 22, 2024
@mergify mergify bot merged commit 16698b1 into solana-labs:master Jan 22, 2024
36 checks passed
@brooksprumo brooksprumo deleted the errors/fs-err/get-bank-snapshot branch January 22, 2024 21:47
@willhickey willhickey mentioned this pull request Mar 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NxPKG NxPKG NxPKG left review comments

@HaoranYi HaoranYi HaoranYi approved these changes

Assignees

@brooksprumo brooksprumo

Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brooksprumo @HaoranYi @NxPKG