This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #35021 +/- ##
=======================================
Coverage 81.6% 81.6%
=======================================
Files 834 830 -4
Lines 224803 224838 +35
=======================================
+ Hits 183467 183504 +37
+ Misses 41336 41334 -2 |
apfitzge
reviewed
Feb 5, 2024
github-actions
bot
added
the
stale
[bot only] Added to stale content; results in auto-close after a week.
label
Feb 20, 2024
apfitzge
reviewed
Feb 20, 2024
github-actions
bot
removed
the
stale
[bot only] Added to stale content; results in auto-close after a week.
label
Feb 21, 2024
tao-stones
force-pushed
the
add_fee_details
branch
from
February 22, 2024 18:14
27e15a4
to
637be2f
Compare
tao-stones
added
the
feature-gate
Pull Request adds or modifies a runtime feature gate
label
Feb 22, 2024
tao-stones
force-pushed
the
add_fee_details
branch
from
February 22, 2024 19:45
637be2f
to
fbd3e82
Compare
apfitzge
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - thanks for introducing the feature for removing the rounding!
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Feb 27, 2024
* add fee_details to fee calculation * fix - no need to round after summing u64 * feature gate on removing unwanted rounding
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
To reward priority fee differently from transaction fee (solana-foundation/solana-improvement-documents#96), priority fee and transaction fee should be separately identified from result of
calculate_fee(...)
Summary of Changes
struct FeeDetails {}
calculate_fee_details(...) -> FeeDetails
calculate_fee(...) -> u64
without changing its logic to minimize impact on call sitesFeature Gate Issue: #34982