-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdk: Do not derive AbiEnum on InstructionError for Solana builds #35038
Conversation
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #35038 +/- ##
=======================================
Coverage 81.6% 81.6%
=======================================
Files 830 830
Lines 224828 224821 -7
=======================================
+ Hits 183504 183516 +12
+ Misses 41324 41305 -19 |
) (cherry picked from commit 3646291)
I am using solana 1.18.18 and anchor 0.30.1, but I still have this same error. Can I just simply ignore this error as the program seemly works well in my testing. $ anchor --version Error: |
The issue you're seeing is unrelated to the bug fixed in this PR, and is related to Anchor. There is some info about it at anza-xyz#1186 |
Problem
The
AbiEnumVisitor
derivation onInstructionError
blows out the stack space for Solana builds, giving the error:Summary of Changes
Since these tests aren't useful for on-chain program builds, and only run with the nightly compiler anyway, don't derive the trait for on-chain programs.
Fixes #35003