chains Merkle shreds in broadcast duplicates #35058
Conversation
behzadnouri
force-pushed
the
chained-merkle-root-duplicates
branch
5 times, most recently
from
f60f2b9 to
e993683
Compare
behzadnouri
force-pushed
the
chained-merkle-root-duplicates
branch
from
e993683 to
72bbc24
Compare
behzadnouri
force-pushed
the
chained-merkle-root-duplicates
branch
from
72bbc24 to
107422c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #35058 +/- ##
===========================================
+ Coverage 0 81.6% +81.6%
===========================================
Files 0 831 +831
Lines 0 224845 +224845
===========================================
+ Hits 0 183540 +183540
- Misses 0 41305 +41305 |
| // Chained Merkle shreds are always discarded in epoch 0, due to | ||
| // feature_set::enable_chained_merkle_shreds. Below can be removed once | ||
| // the feature gated code is removed. | ||
| let should_chain_merkle_shreds = bank.epoch() > 0; |
There was a problem hiding this comment.
to confirm: this was the change that now allows the local cluster tests to pass?
I took a look carl's concern here #35115 (comment) and it should not be a problem for the test, as it sends directly to the partition.
There was a problem hiding this comment.
yes, that is correct.
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
The commit migrates
turbine/src/broadcast_stage/broadcast_duplicates_run.rs
to use chained Merkle shreds variant.
(cherry picked from commit 1b9dfd4)
Problem
Use chained Merkle shreds in
turbine/src/broadcast_stage/broadcast_duplicates_run.rs.Summary of Changes
Chains Merkle shreds in broadcast duplicates.