Runtime: Bank: Prioritize additional builtins for init and feature activations #35267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #35267 +/- ##
========================================
Coverage 81.7% 81.8%
========================================
Files 836 836
Lines 224834 224951 +117
========================================
+ Hits 183847 184022 +175
+ Misses 40987 40929 -58 |
buffalojoec
force-pushed
the
override-builtins-2
branch
from
6f57f5b to
8c00af9
Compare
buffalojoec
force-pushed
the
override-builtins-2
branch
2 times, most recently
from
6b5706f to
86c59f8
Compare
buffalojoec
changed the title
buffalojoec
force-pushed
the
override-builtins-2
branch
from
86c59f8 to
a7fe30c
Compare
buffalojoec
force-pushed
the
override-builtins-2
branch
from
a7fe30c to
c8663a4
Compare
|
This repository is no longer in use. Please re-open this pull request in the agave repo: https://github.com/anza-xyz/agave |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In order to expand on testing feature activation behavior for builtins, the bank should have a method for providing additional test builtins to
apply_feature_activations.Summary of Changes
Add an additional parameter to
apply_feature_activationsandapply_builtin_program_feature_transitionsto allow for providing additional test builtins to be activated on their correspondingfeature_id.Additionally, I've modified the iterator over
BUILTINSto opt for any additional builtins with the same program ID, to ensure they are only added when the feature dictates so.