Proposal: Use SanitizedMessage when possible in svm/account_loader.rs
#35390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In
svm/src/account_loader.rs
SanitizedTransaction
is passed between functions in many cases, when just aSanitizedMessage
can work without any loss.Summary of Changes
I swapped
SanitizedTransaction
forSanitizedMessage
in the pertinent locations. One item to be cautious in the review is that I removed one if-condition (see line 131 inaccount_loader.rs
) marked as unused, because the message was previously sanitized, so that the check would never evaluate true.