Package solana as a snap #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was created as follows: $ snapcraft export-login --snaps solana --channels beta,edge snapcraft.credentials $ openssl aes-256-cbc -e -in snapcraft.credentials -out snapcraft.credentials.enc
…rt on the same machine
Codecov Report
@@ Coverage Diff @@
## master #377 +/- ##
==========================================
+ Coverage 90.8% 91.06% +0.25%
==========================================
Files 36 36
Lines 3490 3490
==========================================
+ Hits 3169 3178 +9
+ Misses 321 312 -9
Continue to review full report at Codecov.
|
garious
approved these changes
Jun 19, 2018
|
Landing this as is to get CPU snaps moving. Will work on CUDA next as a separate PR, as well as documenting snap usage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards #372
CUDA support not added yet.