Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve ledger initialization for fullnode #380

Merged
merged 1 commit into from
Jun 19, 2018

Conversation

rob-solana
Copy link
Contributor

  • use a line iterator on stdin instead of a line iterator on a buffer
  • move some unwrap() to expect(), documenting failures
  • bind entry type earlier (for kicks)

 * use a line iterator on stdin instead of a line iterator on a buffer
 * move some unwrap() to expect(), documenting failures
 * bind entry type earlier (for kicks)
@garious garious added the automerge Merge this Pull Request automatically once CI passes label Jun 19, 2018
@solana-grimes solana-grimes merged commit 6aced92 into solana-labs:master Jun 19, 2018
@rob-solana rob-solana deleted the stream-ledger-load branch June 19, 2018 16:30
@codecov
Copy link

codecov bot commented Jun 19, 2018

Codecov Report

Merging #380 into master will increase coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
+ Coverage   90.78%   91.06%   +0.27%     
==========================================
  Files          36       36              
  Lines        3493     3490       -3     
==========================================
+ Hits         3171     3178       +7     
+ Misses        322      312      -10
Impacted Files Coverage Δ
src/entry.rs 98.85% <0%> (-0.04%) ⬇️
src/crdt.rs 85.36% <0%> (+1.15%) ⬆️
src/tvu.rs 99.27% <0%> (+1.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75997e6...efd488c. Read the comment docs.

vkomenda pushed a commit to vkomenda/solana that referenced this pull request Aug 29, 2021
faddat pushed a commit to faddat/solana that referenced this pull request Apr 6, 2024
…abs#380)

* feat: include replaced blockhash in RPC simulation response

* rename blockhash field to `replacement_blockhash`

* add tests to ensure replacement_blockhash is returning correctly

* fixed tests

* fixed tests again for real this time?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants