enable flaky local cluster tests #5616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParthDesai
force-pushed
the
parth/enable-flaky-local-cluster-test
branch
2 times, most recently
from
3d2d291 to
602f051
Compare
carllin
reviewed
Aug 26, 2019
local_cluster/src/cluster_tests.rs
Outdated
| for validator in &cluster_nodes { | ||
| if ignore_nodes.contains(&validator.id) { | ||
| continue; | ||
| let sigResult = |
There was a problem hiding this comment.
@ParthDesai, there's usually a fundamental issue in the protocol when the signature isn't being confirmed, which needs to be root caused. Indeed the purpose of this function is to send a transaction to each specific validator, and to check that the transaction then propagates to the rest of the network. Thus, a failure to get the transaction signature on any iteration of this loop should fail the entire test, and we shouldn't retry with another client.
There was a problem hiding this comment.
@carllin understood.
There was a problem hiding this comment.
@carllin anyways, was just expertimenting with different things to get any useful debug information.
ParthDesai
force-pushed
the
parth/enable-flaky-local-cluster-test
branch
from
0979a6f to
d3394df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some of tests in
local_clusterpackage fails only in ci. This PR is going to be used to figure out the reason and fix the issue.Summary of Changes
stablejob for quick iterationFixes #5350