Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Start validators in parallel in multinode test #727

Merged
merged 1 commit into from
Jul 23, 2018

Conversation

pgarg66
Copy link
Contributor

@pgarg66 pgarg66 commented Jul 21, 2018

No description provided.

@pgarg66 pgarg66 requested a review from aeyakovenko July 21, 2018 23:27
@pgarg66
Copy link
Contributor Author

pgarg66 commented Jul 21, 2018

The test is failing at "assert_eq!(consecutive_success, 10);"

Copy link
Member

@aeyakovenko aeyakovenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! does it help us start a larger number of validators?

@aeyakovenko
Copy link
Member

@pgarg what number of validators is it failing for? There could be other problems we need to fix

@pgarg66
Copy link
Contributor Author

pgarg66 commented Jul 23, 2018

The failure is intermittent. It failed even with 60 node count.
The test did not improve for higher node count.

@pgarg66
Copy link
Contributor Author

pgarg66 commented Jul 23, 2018

I think, we can merge this one, and push other fixes in separate PRs

@pgarg66 pgarg66 merged commit 166099b into solana-labs:master Jul 23, 2018
@pgarg66 pgarg66 deleted the dynamic-network-test branch July 23, 2018 16:27
vkomenda pushed a commit to vkomenda/solana that referenced this pull request Aug 29, 2021
Bumps [eslint](https://github.com/eslint/eslint) from 7.11.0 to 7.12.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v7.11.0...v7.12.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants