Rename blocktree to blockstore #7757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/solana-labs/tour-de-sol will need to be ported to the new names as well |
carllin
previously approved these changes
Jan 10, 2020
Codecov Report
@@ Coverage Diff @@
## master #7757 +/- ##
========================================
+ Coverage 81.8% 81.8% +<.1%
========================================
Files 241 241
Lines 50967 51020 +53
========================================
+ Hits 41720 41766 +46
- Misses 9247 9254 +7 |
garious
force-pushed
the
rename-blocktree
branch
from
6361fcf
to
4d58148
Compare
garious
force-pushed
the
rename-blocktree
branch
from
4d58148
to
7540e56
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jan 13, 2020
automerge (cherry picked from commit b5dba77) # Conflicts: # core/src/ledger_cleanup_service.rs # core/src/poh_recorder.rs # core/src/replay_stage.rs # core/src/shred_fetch_stage.rs # core/src/transaction_status_service.rs # core/src/window_service.rs # core/tests/ledger_cleanup.rs # local-cluster/src/cluster_tests.rs
solana-grimes
pushed a commit
that referenced
this pull request
Jan 14, 2020
sakridge
pushed a commit
to sakridge/solana
that referenced
this pull request
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Blocktree isn't a tree. It's a store and when the blocks connect, those blocks form a tree.
Summary of Changes
Call it what it is. As discussed in the validator design proposal, rename Blocktree to Blockstore.