Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On a testnet with very high stakes,
solana get-block-time
returns unexpected, unrealistic value (see #7781 ).Stake-weighted blocktime calculation accumulators currently use u64 integer types; stake quantities are represented in lamports, and also use the u64 integer type. Thus, it is easy to make the stake-weighted timestamp calculation overflow when multiplying a moderately high stake number with a UnixTimestamp (i64).
(This bug produces a skewed timestamp on testnet, instead of panicking the node as it does in the unit test; TIL Rust only checks for integer overflow in debug builds.)
Summary of Changes
Fixes #7781