Add retry mechanism when downloading genesis and snapshots #8467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the validator selects an RPC node to download genesis or a snapshot from, it currently aborts the process on any failure. This is ripe for exploitation (as we saw in the SLP2 boot) and can cause problems such as #8406 when the selected RPC node returns bad data.
While this PR does not add any additional genesis/snapshot validation (that's for a follow-up), it adds the ability to blacklist any RPC nodes that fail to respond or return unexpected results. Caveats:
--trusted-validator
nodes are never blacklistedProgress towards #8406